Re: [PATCH v1 0/3] rust: make various `alloc` functions `const fn`

[Onur Özkan]

On Sun, 20 Jul 2025 16:43:49 +0200
"Benno Lossin" <lossin@xxxxxxxxxx> wrote:

> On Sun Jul 20, 2025 at 11:48 AM CEST, Onur Özkan wrote:
> > This patch series makes various functions in the
> > `alloc` crate const fn.
> >
> > Each patch corresponds to a different module within
> > the same `alloc` crate.
> >
> > Onur Özkan (3):
> >   rust: make `allocator::aligned_size` a `const fn`
> >   rust: make `ArrayLayout::new_unchecked` a `const fn`
> >   rust: make `kvec::Vec` functions `const fn`
> >
> >  rust/kernel/alloc/allocator.rs |  2 +-
> >  rust/kernel/alloc/kvec.rs      | 10 +++++-----
> >  rust/kernel/alloc/layout.rs    |  2 +-
> >  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> This looks sensible, any particular reason for why you need them
> const?
> 
> For the entire series:
> 
> Reviewed-by: Benno Lossin <lossin@xxxxxxxxxx>
> 
> ---
> Cheers,
> Benno

Personally, I don't have a specific reason. I thought the change is
harmless and might extend functionality for other people in the future.
It could also (although less likely) help the compiler optimize things
further.

Regards,
Onur