Re: cdrom: cdrom_mrw_exit() NULL ptr deref
From: Phillip Potter
Date: Sun Jul 20 2025 - 07:56:08 EST
On Tue, Jul 15, 2025 at 12:32:22PM +0900, Sergey Senozhatsky wrote:
> On (25/07/14 08:22), Jens Axboe wrote:
> > This just looks totally broken, the cdrom layer trying to issue block
> > layer commands at exit time. Perhaps something like the below (utterly
> > untested) patch would be an improvement. Also gets rid of the silly
> > ->exit() hook which exists just for mrw.
>
> I don't have a CD/DVD drive to test this, but from what I can tell
> the patch looks good to me. Thanks for taking a look!
Hi Sergey,
Just to say, I haven't forgotten this :-) Have run a few tests with the
patch and so far looks all good. Still been unable to replicate the
specific issue though. Assuming my testing uncovers nothing else, I will
revert to Jens with fully crafted patch submission in next day or two.
Regards,
Phil