Re: [PATCH] hwmon: (gsc-hwmon) fix fan pwm setpoint show functions

[Guenter Roeck]

On Fri, Jul 18, 2025 at 01:02:59PM -0700, Tim Harvey wrote:
> The Linux hwmon sysfs API values for pwmX_auto_pointY_pwm represent an
> integer value between 0 (0%) to 255 (100%) and the pwmX_auto_pointY_temp
> represent millidegrees Celcius.
> 
> Commit a6d80df47ee2 ("hwmon: (gsc-hwmon) fix fan pwm temperature
> scaling") properly addressed the incorrect scaling in the
> pwm_auto_point_temp_store implementation but erroneously scaled
> the pwm_auto_point_pwm_show (pwm value) instead of the
> pwm_auto_point_temp_show (temp value) resulting in:
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_pwm
>  25500
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_temp
>  4500
> 
> Fix the scaling of these attributes:
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_pwm
>  255
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_temp
>  45000
> 
> Fixes: a6d80df47ee2 ("hwmon: (gsc-hwmon) fix fan pwm temperature scaling")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>

Applied.

Thanks,
Guenter