Re: [PATCH v4 6/6] rust: list: remove OFFSET constants

[Tamir Duberstein]

On Sat, Jul 19, 2025 at 5:09 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Wed, Jul 9, 2025 at 9:31 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > -/// Declares that this type has a `ListLinks<ID>` field at a fixed offset.
> > +/// Declares that this type has a [`ListLinks<ID>`] field.
>
> I was applying this series the other day, and I noticed these
> doc-related changes in the patch, which are appreciated (I think you
> did it to make it consistent with the other lines you were adding with
> intra-doc links), but I think in general it is better to clean those
> separately in a patch first.
>
> I am mentioning it because the docs do not build due to those --
> please check the `rustdoc` target for patches, especially if it is a
> non-trivial change.
>
> I also did another change to make the examples (in the other patch)
> build with the minimum Rust version. It is good to test that too,
> since sometimes that can slip, especially as the window of versions
> grow.
>
> Anyway, the examples/series here caught another issue with a previous
> patch, so that is good news :)
>
> Thanks!
>
> Cheers,
> Miguel

Thanks Miguel, will do in the future!
Tamir