[tip: locking/core] leds: lp8860: Check return value of devm_mutex_init()
From: tip-bot2 for Thomas Weißschuh
Date: Sat Jul 19 2025 - 13:41:24 EST
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 3b07bb900af7f43f13f9ff398b4c6ca1dee217cd
Gitweb: https://git.kernel.org/tip/3b07bb900af7f43f13f9ff398b4c6ca1dee217cd
Author: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
AuthorDate: Tue, 17 Jun 2025 19:08:13 +02:00
Committer: Boqun Feng <boqun.feng@xxxxxxxxx>
CommitterDate: Fri, 11 Jul 2025 15:11:19 -07:00
leds: lp8860: Check return value of devm_mutex_init()
devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be
marked as unusable and trigger errors on usage.
Add the missed check.
Fixes: 87a59548af95 ("leds: lp8860: Use new mutex guards to cleanup function exits")
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Acked-by: Andrew Davis <afd@xxxxxx>
Acked-by: Lee Jones <lee@xxxxxxxxxx>
Signed-off-by: Boqun Feng <boqun.feng@xxxxxxxxx>
Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-2-d9e449f4d224@xxxxxxxxxxxxxx
---
drivers/leds/leds-lp8860.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 52b97c9..0962c00 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -307,7 +307,9 @@ static int lp8860_probe(struct i2c_client *client)
led->client = client;
led->led_dev.brightness_set_blocking = lp8860_brightness_set;
- devm_mutex_init(&client->dev, &led->lock);
+ ret = devm_mutex_init(&client->dev, &led->lock);
+ if (ret)
+ return dev_err_probe(&client->dev, ret, "Failed to initialize lock\n");
led->regmap = devm_regmap_init_i2c(client, &lp8860_regmap_config);
if (IS_ERR(led->regmap)) {