Re: [PATCH v3] staging: sm750fb: make fixId array static const char * const

From: Dan Carpenter
Date: Fri Jul 18 2025 - 17:12:16 EST


On Fri, Jul 18, 2025 at 04:48:22PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning for the fixId array only:
> "WARNING: static const char * array should probably be
> static const char * const"
>
> The g_fbmode array cannot be made const as it is modified at runtime
> in lynxfb_setup() and lynx_alloc().
>
> Signed-off-by: Ignacio Peña <ignacio.pena87@xxxxxxxxx>
> ---
> v3: Apologies for the confusion. v2 accidentally included changes to
> g_fbmode which breaks the build. This version ONLY changes fixId
> which is never modified.

Heh. No. The patch marked v2 was fine. Either v2 or this v3 is fine.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter