Re: [PATCH v2] staging: sm750fb: make fixId array static const char * const

From: Dan Carpenter
Date: Fri Jul 18 2025 - 17:07:15 EST


On Fri, Jul 18, 2025 at 04:32:18PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning for the fixId array only:
> "WARNING: static const char * array should probably be
> static const char * const"
>
> The g_fbmode array cannot be made const as it is modified at runtime
> in lynxfb_setup() and lynx_alloc().
>
> Signed-off-by: Ignacio Peña <ignacio.pena87@xxxxxxxxx>
> ---
> v2: Only change fixId array. The g_fbmode array is modified at
> runtime (lines 786, 788, 949, 953) and cannot be const.

There you go. That works.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter