Re: [PATCH 1/8] dt-bindings: power: qcom-rpmpd: split RPMh domains definitions

From: Konrad Dybcio
Date: Fri Jul 18 2025 - 13:21:44 EST


On 7/18/25 6:13 PM, Dmitry Baryshkov wrote:
> Historically both RPM and RPMh domain definitions were a part of the
> same, qcom-rpmpd.h header. Now as we have a separate header for RPMh
> definitions, qcom,rpmhpd.h, move all RPMh power domain definitions to
> that header.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---

[...]

> -/* SC8280XP Power Domain Indexes */
> -#define SC8280XP_CX 0
> -#define SC8280XP_CX_AO 1
> -#define SC8280XP_DDR 2
> -#define SC8280XP_EBI 3
> -#define SC8280XP_GFX 4
> -#define SC8280XP_LCX 5
> -#define SC8280XP_LMX 6
> -#define SC8280XP_MMCX 7
> -#define SC8280XP_MMCX_AO 8
> -#define SC8280XP_MSS 9
> -#define SC8280XP_MX 10
> -#define SC8280XP_MXC 12
> -#define SC8280XP_MX_AO 11
> -#define SC8280XP_NSP 13
> -#define SC8280XP_QPHY 14
> -#define SC8280XP_XO 15
> -
> -/* SDM845 Power Domain performance levels */

I was never a fan of these comments but whatever, it's an include

if the dt folks don't object, this is good

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad