Re: [PATCH v9 4/6] input: pf1550: add onkey support

[Sean Nyekjaer]

On Wed, Jul 16, 2025 at 11:11:47AM +0100, Samuel Kayode via B4 Relay wrote:
> From: Samuel Kayode <samuel.kayode@xxxxxxxxxxxxxxxxxxxx>
> 
> Add support for the onkey of the pf1550 PMIC.
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Signed-off-by: Samuel Kayode <samuel.kayode@xxxxxxxxxxxxxxxxxxxx>
> ---

[...]

> +
> +static int pf1550_onkey_probe(struct platform_device *pdev)
> +{
> +	struct onkey_drv_data *onkey;
> +	struct input_dev *input;
> +	bool key_power = false;
> +	int i, irq, error;
> +
> +	onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL);
> +	if (!onkey)
> +		return -ENOMEM;
> +
> +	onkey->dev = &pdev->dev;
> +
> +	onkey->pf1550 = dev_get_drvdata(pdev->dev.parent);
> +	if (!onkey->pf1550->regmap)
> +		return dev_err_probe(&pdev->dev, -ENODEV,
> +				     "failed to get regmap\n");
> +
> +	onkey->wakeup = device_property_read_bool(pdev->dev.parent,
> +						  "wakeup-source");
> +
> +	if (device_property_read_bool(pdev->dev.parent,
> +				      "nxp,disable-key-power")) {
> +		error = regmap_write(onkey->pf1550->regmap,
> +				     PF1550_PMIC_REG_PWRCTRL1, 0);

I would use regmap_clear_bits() here.

/Sean