Re: [PATCH] drm/sitronix/st7571-i2c: Make st7571_panel_data to be static variables

[Thomas Zimmermann]

Hi Javier

Am 18.07.25 um 09:25 schrieb Javier Martinez Canillas:
> The kernel test robot reported that sparse gives the following warnings:
>
> make C=2 M=drivers/gpu/drm/sitronix/
>    CC [M]  st7571-i2c.o
>    CHECK   st7571-i2c.c
> st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static?
> st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
>    MODPOST Module.symvers
>    LD [M]  st7571-i2c.ko
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507180503.nfyD9uRv-lkp@xxxxxxxxx
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> ---
>
>   drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
> index 453eb7e045e5..7fe5b69e6f2f 100644
> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
> @@ -1024,7 +1024,7 @@ static void st7571_remove(struct i2c_client *client)
>   	drm_dev_unplug(&st7571->dev);
>   }
>   
> -struct st7571_panel_data st7567_config = {
> +static struct st7571_panel_data st7567_config = {

Make it 'static const' please. Here and below.

Best regards
Thomas

>   	.init = st7567_lcd_init,
>   	.parse_dt = st7567_parse_dt,
>   	.constraints = {
> @@ -1036,7 +1036,7 @@ struct st7571_panel_data st7567_config = {
>   	},
>   };
>   
> -struct st7571_panel_data st7571_config = {
> +static struct st7571_panel_data st7571_config = {
>   	.init = st7571_lcd_init,
>   	.parse_dt = st7571_parse_dt,
>   	.constraints = {

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)