[PATCH 2/2] cgroup: Fix reference count leak when cft->open is NULL

From: Zijiang Huang
Date: Fri Jul 18 2025 - 07:56:18 EST


When cft->open is NULL, it will cause ctx namespace reference count leak.

Signed-off-by: Zijiang Huang <kerayhuang@xxxxxxxxxxx>
Reviewed-by: Hao Peng <flyingpeng@xxxxxxxxxxx>
---
kernel/cgroup/cgroup.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index a723b7dc6e4e..9bde0f4be687 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -4134,8 +4134,10 @@ static int cgroup_file_open(struct kernfs_open_file *of)
get_cgroup_ns(ctx->ns);
of->priv = ctx;

- if (!cft->open)
+ if (!cft->open) {
+ get_cgroup_ns(ctx->ns);
return 0;
+ }

ret = cft->open(of);
if (ret) {
--
2.43.5