Re: [PATCH 1/2] crypto: engine: remove request batching support

[Herbert Xu]

On Fri, Jul 11, 2025 at 09:29:31PM +0300, Ovidiu Panait wrote:
> Remove request batching support from crypto_engine, as there are no
> drivers using this feature and it doesn't really work that well.
> 
> Instead of doing batching based on backlog, a more optimal approach
> would be for the user to handle the batching (similar to how IPsec
> can hook into GSO to get 64K of data each time or how block encryption
> can use unit sizes much greater than 4K).
> 
> Suggested-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@xxxxxxxxx>
> ---
> Cc: freude@xxxxxxxxxxxxx
> Cc: dengler@xxxxxxxxxxxxx
> Cc: linux-s390@xxxxxxxxxxxxxxx
> Cc: horia.geanta@xxxxxxx
> Cc: pankaj.gupta@xxxxxxx
> Cc: gaurav.jain@xxxxxxx
> Cc: arei.gonglei@xxxxxxxxxx
> Cc: virtualization@xxxxxxxxxxxxxxx
> 
>  arch/s390/crypto/paes_s390.c               |  2 +-
>  arch/s390/crypto/phmac_s390.c              |  2 +-
>  crypto/crypto_engine.c                     | 25 +---------------------
>  drivers/crypto/caam/jr.c                   |  3 +--
>  drivers/crypto/virtio/virtio_crypto_core.c |  2 +-
>  include/crypto/engine.h                    |  1 -
>  include/crypto/internal/engine.h           |  4 ----
>  7 files changed, 5 insertions(+), 34 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt