Re: [PATCH v15 19/34] fs/resctrl: Pass struct rdtgroup instead of individual members

[Reinette Chatre]

Hi Babu,

On 7/8/25 3:17 PM, Babu Moger wrote:
> Reading monitoring data for a monitoring group requires both the RMID and
> CLOSID. The RMID and CLOSID are members of struct rdtgroup but passed
> separately to several functions involved in retrieving event data.
> 
> When "mbm_event" counter assignment mode is enabled, a counter ID is
> required to read event data. The counter ID is obtained through
> mbm_cntr_get(), which expects a struct rdtgroup pointer.
> 
> Provide a pointer to the struct rdtgroup as parameter to functions involved
> in retrieving event data to simplify access to RMID, CLOSID, and counter
> ID.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> ---

...

> @@ -429,9 +431,11 @@ static int __mon_event_count(u32 closid, u32 rmid, struct rmid_read *rr)
>   * __mon_event_count() is compared with the chunks value from the previous
>   * invocation. This must be called once per second to maintain values in MBps.
>   */
> -static void mbm_bw_count(u32 closid, u32 rmid, struct rmid_read *rr)
> +static void mbm_bw_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)

Function comments need an update to match this change.

>  {
>  	u64 cur_bw, bytes, cur_bytes;
> +	u32 closid = rdtgrp->closid;
> +	u32 rmid = rdtgrp->mon.rmid;
>  	struct mbm_state *m;
>  
>  	m = get_mbm_state(rr->d, closid, rmid, rr->evtid);

Reinette