Re: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

[Jeremy Kerr]

Hi YH,

> We're planning to split the MCTP controller driver into two separate
> drivers for AST2600 and AST2700, removing the AST2600-specific
> workarounds in the process for improving long-term maintainability.
> And it's part of the reason we want to decouple the binding protocol
> logic into its own layer.

The split is entirely up to you (and sounds reasonable), but the
"binding protocol logic" is really minimal. I would think a couple of
shared helper functions should be sufficient?

> Would it be preferable to create a directory such as net/mctp/aspeed/
> to host the abstraction layer alongside the hardware-specific
> drivers?

Just put them in the top-level at drivers/net/mctp/ for now. There's not
much in there at present, so will be simple to keep organised. If you
end up with two drivers and a common set of utils between the two,
that's a total of four files, which I think we can manage.

Cheers,


Jeremy