Re: [PATCH for-next] cxl: Fix -Werror=return-type in cxl_decoder_detach()

[Dave Jiang]

On 7/16/25 8:12 PM, Li Zhijian wrote:
> Fix following compiling errors:
> In file included from ../drivers/cxl/core/pmu.c:10:
> ../drivers/cxl/core/core.h: In function ‘cxl_decoder_detach’:
> ../drivers/cxl/core/core.h:65:1: error: no return statement in function returning non-void [-Werror=return-type]
>  }
>  ^
> cc1: some warnings being treated as errors
>   CC [M]  drivers/nvdimm/claim.o
> make[6]: *** [../scripts/Makefile.build:287: drivers/cxl/core/pmu.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
>   CC [M]  drivers/infiniband/core/verbs.o
> 
> Fixes: b3a88225519c ("cxl/region: Consolidate cxl_decoder_kill_region() and cxl_region_detach()")
> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>

Thanks! I applied to cxl/next

1d0d1bc44e98dc90d478badb40de5e3adb747c2e


> ---
> I'm curious why the LKP robot didn't report this.

Yes. Odd. I guess randconf has not turned off CONFIG_CXL_REGION

DJ 

> ---
>  drivers/cxl/core/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h
> index 705a5f09aa78..2669f251d677 100644
> --- a/drivers/cxl/core/core.h
> +++ b/drivers/cxl/core/core.h
> @@ -62,6 +62,7 @@ static inline int cxl_decoder_detach(struct cxl_region *cxlr,
>  				     struct cxl_endpoint_decoder *cxled,
>  				     int pos, enum cxl_detach_mode mode)
>  {
> +	return 0;
>  }
>  static inline int cxl_region_init(void)
>  {