Re: [PATCH] dt-bindings: trivial-devices: Add Garmin lidar-lite-v3

From: Rodrigo Gobbi
Date: Thu Jul 17 2025 - 18:32:13 EST


> As a general rule of thumb, using the driver as justification for
> dt-bindings is never a good reason. The bindings describe the hardware,
> not the driver.

Looks like I`ve failed to double-check the datasheet here, sorry for that,
I`ll try to remember that in future occasions.

> Assuming I found the correct datasheet [1], I see a power enable pin
> and a mode control pin, so I would say that this isn't a trivial device.
> Therefore this will need it's own new file. We could at least add
> power-gpios and power-supply properties. How to handle the mode pin
> isn't so clear to me though, so might omit that for now.

Agree, actually, I was wondering here if the lidar-lite-v2 ref that I`ve found
when adding the grmn,lidar-lite-v3 is actually a trivial.
It was originally added as trivial over txt file at [1] and then converted to yaml but
it looks like it is also not a trivial considering some refs at [2] and [3] (not official docs).
At those refs, I can see the same enable/mode pins.

Should we also move that out of trivial in a dedicated binding or should we keep as is
considering those docs are not official/device is very old?
Tks and regards!

[1] https://github.com/torvalds/linux/commit/12280bd3d5d7e1ba1dd60ba0bd4412f4056fc028
[2] https://www.electrokit.com/upload/product/41013/41013964/lidarlite2DS.pdf
[3] https://www.14core.com/wp-content/uploads/2017/03/LIDAR-Lite-v2-Datasheet.pdf