Re: [PATCH] riscv: dts: starfive: jh7110-milkv-mars sort properties

[Conor Dooley]

On Thu, Jul 17, 2025 at 12:06:57AM -0700, E Shattow wrote:
> 
> 
> On 7/16/25 08:28, Conor Dooley wrote:
> > On Wed, Jul 16, 2025 at 02:17:34AM -0700, Emil Renner Berthing wrote:
> >> E Shattow wrote:
> >>> Improve style with node property order sort of common properties before
> >>> vendor prefixes
> >>>
> >>> Signed-off-by: E Shattow <e@xxxxxxxxxxxx>
> >>
> >> Thanks!
> >>
> >> Acked-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx>
> > 
> > I'm going to pick this up, but it may be very late for 6.17.
> 
> Yes. The other questionable sort style in this dts I was looking at are
> whether we want "compatible" before "model" in the root '/' node?  And

I think usually model comes first, yeah. Whether that's worth doing
something about, I'll leave up to you.

> then why we have this common pattern of 'pinmux' (or pinctrl*)
> prioritized firstly in the natural sort order, also pinctrl-names before
> pinctrl-N is a common pattern that seems an arbitrary reversal of
> natural sort order?

Usually "foo" is followed by "foo-names", but pinctrl does appear to be
a bit different since everything has a -something suffix. Skimming, it
looks like there are actually more instances where pinctrl-names appears
before pinctrl-N.

Attachment: signature.asc
Description: PGP signature