Re: [PATCH 6/9] usb: vhci-hcd: Fix block comments
From: Greg Kroah-Hartman
Date: Thu Jul 17 2025 - 12:19:39 EST
On Thu, Jul 17, 2025 at 06:54:55PM +0300, Cristian Ciocaltea wrote:
> Address a couple of comment formatting issues indicated by
> checkpatch.pl:
>
> WARNING: Block comments use a trailing */ on a separate line
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> ---
> drivers/usb/usbip/vhci_hcd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 53691d5e77d386b0b0e16fe9d08824baa04c0b1e..a2a8418c77e58ae9e06d673d0012b972c92ee33b 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -879,7 +879,8 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
> priv = urb->hcpriv;
> if (!priv) {
> /* URB was never linked! or will be soon given back by
> - * vhci_rx. */
> + * vhci_rx.
> + */
The comment should just be one line long.
> spin_unlock_irqrestore(&vhci->lock, flags);
> return -EIDRM;
> }
> @@ -936,7 +937,8 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
> unlink->unlink_seqnum = priv->seqnum;
>
> /* send cmd_unlink and try to cancel the pending URB in the
> - * peer */
> + * peer
> + */
Same here.
thanks,
greg k-h