Re: [PATCH 1/2] misc: ti-fpc202: remove unneeded direction check

[Romain Gantois]

Hi Bartosz,

On Thursday, 17 July 2025 15:03:55 CEST Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
> lines"), the GPIO core makes sure values cannot be set on input lines.
> Remove the unnecessary check.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
>  drivers/misc/ti_fpc202.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index f7cde245ac95..ca415ef45cbe 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -125,9 +125,6 @@ static void fpc202_gpio_set(struct gpio_chip *chip,
> unsigned int offset, int ret;
>  	u8 val;
> 
> -	if (fpc202_gpio_get_dir(offset) == GPIO_LINE_DIRECTION_IN)
> -		return;
> -
>  	ret = fpc202_read(priv, FPC202_REG_OUT_A_OUT_B_VAL);
>  	if (ret < 0) {
>  		dev_err(&priv->client->dev, "Failed to set GPIO %d value! err 
%d\n",
> offset, ret);

LGTM

Reviewed-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part.