Re: [PATCH] pNFS: Fix uninited ptr access in ext_tree_encode_commit

From: Dan Carpenter
Date: Thu Jul 17 2025 - 10:43:16 EST


On Thu, Jul 17, 2025 at 05:34:04PM +0300, Sergey Bashirov wrote:
> Current implementation of the function assumes that the provided buffer
> can always accommodate at least one encoded extent. This patch adds
> handling of all theoretically possible values of be_prev, so that
> ext_tree_encode_commit makes no assumptions about the provided buffer
> size, and static checks pass without warnings.
>
> Fixes: d84c4754f874 ("pNFS: Fix extent encoding in block/scsi layout")
> Addresses-Coverity-ID: 1647611 ("Memory - illegal accesses (UNINIT)")
> Signed-off-by: Sergey Bashirov <sergeybashirov@xxxxxxxxx>
> ---

Generally, we wouldn't put a Fixes tag here because it's just silencing
a false positive. But also putting a Fixes tag is fine. Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter