Re: [PATCH 1/3] dt-bindings: mfd: Add power-button option for TI TPS6594 PMIC

[Michael Walle]

Hi,

> > Someone knowing the device should come with arguments whether
> > other states for this are useful at all. Or not useful and then argument
> > that in commit msg for example.
> The other states are not useful for the kernel. Only the push button
> has a need for an interrupt handler. The other states the PMIC handles
> on its own.
>
> What exactly do you want me to change?

Because the driver isn't setting the configuration anyway, wouldn't
it be possible to read the config bits (Register 0x3c, bits 7-6) to
figure out whether the pin is configured as power-button instead of
having this property?

I mean, the correct config is likely stored in the NVM anyway, and
reconfiguring it to another value seems unlikely.

-michael

Attachment: signature.asc
Description: PGP signature