Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add ov2735 sensor

From: Krzysztof Kozlowski
Date: Thu Jul 17 2025 - 07:01:04 EST


On 17/07/2025 09:28, Hardevsinh Palaniya wrote:
> Hi Krzysztof,
>
>> On Wed, Jul 16, 2025 at 07:14:16PM +0530, Hardevsinh Palaniya wrote:
>>> +        properties:
>>> +          data-lanes:
>>> +            items:
>>> +              - const: 1
>>> +              - const: 2
>>> +          link-frequencies: true
>>
>> Drop
>>
>> I don't understand why this appeared. I don't think anyone asked for it?
>
> Laurent suggested validating the link frequency in the Device Tree.
>
> Link[1]: https://lore.kernel.org/linux-media/20250710212131.GG22436@xxxxxxxxxxxxxxxxxxxxxxxxxx/

... and I do not see here validation "that the link frequencies
specified in DT match".

How do you validate that 1111 Hz is not / is a valid link frequency? How
did you exactly resolve the comment about validating?

If your hardware operates on specific link frequencies, list them.
Otherwise this is redundant - validates nothing, changes nothing, does
not make the code more obvious.


Best regards,
Krzysztof