RE: [PATCH v2 net-next 01/14] dt-bindings: ptp: add NETC Timer PTP clock

[Wei Fang]

> On 17/07/2025 10:30, Wei Fang wrote:
> >> On Wed, Jul 16, 2025 at 03:30:58PM +0800, Wei Fang wrote:
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - pci1131,ee02
> >>> +
> >>> +  reg:
> >>> +    maxItems: 1
> >>> +
> >>> +  clocks:
> >>> +    maxItems: 1
> >>> +    description:
> >>> +      The reference clock of NETC Timer, if not present, indicates that
> >>> +      the system clock of NETC IP is selected as the reference clock.
> >>
> >> If not present...
> >>
> >>> +
> >>> +  clock-names:
> >>
> >> ... this also is not present...
> >>
> >>> +    description:
> >>> +      NETC Timer has three reference clock sources, set
> >> TMR_CTRL[CK_SEL]
> >>> +      by parsing clock name to select one of them as the reference clock.
> >>> +      The "system" means that the system clock of NETC IP is used as the
> >>> +      reference clock.
> >>> +      The "ccm_timer" means another clock from CCM as the reference
> >> clock.
> >>> +      The "ext_1588" means the reference clock comes from external IO
> >> pins.
> >>> +    enum:
> >>> +      - system
> >>
> >> So what does system mean?
> >>
> >
> > "system" is the system clock of the NETC subsystem, we can explicitly specify
> > this clock as the PTP reference clock of the Timer in the DT node. Or do not
> > add clock properties to the DT node, it implicitly indicates that the reference
> > clock of the Timer is the "system" clock.
> >
> 
> Eh, no. If absence of clock input means you are using specific clock
> input it is contradictory to the first. You cannot use some clock input
> if you claim that it can be missing.
> 
> You define here clock inputs. This is what this property is about.
> 

Okay, I will remove "system", due to it is the system clock of NETC IP,
which is always available to Timer.