Re: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire system_counterval_t in get_time_fn() callback

From: Mor Bar-Gabay
Date: Thu Jul 17 2025 - 05:59:16 EST


On 09/07/2025 20:28, Markus Blöchl wrote:
get_time_fn() callback implementations are expected to fill out the
entire system_counterval_t struct as it may be initially uninitialized.

This broke with the removal of convert_art_to_tsc() helper functions
which left use_nsecs uninitialized.

Assign the entire struct again.

Fixes: bd48b50be50a ("e1000e: Replace convert_art_to_tsc()")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Markus Blöchl <markus@xxxxxxxxx>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
Reviewed-by: Vitaly Lifshits <vitaly.lifshits@xxxxxxxxx>
---
Notes:
Related-To: <https://lore.kernel.org/lkml/txyrr26hxe3xpq3ebqb5ewkgvhvp7xalotaouwludjtjifnah2@7tmgczln4aoo/>

Changes in v2:
- Add Lakshmi in Cc:
- Add Signed-off-by: trailer which was lost in b4 workflow
- Link to v1: https://lore.kernel.org/r/20250709-e1000e_crossts-v1-1-f8a80c792e4f@xxxxxxxxx
---
drivers/net/ethernet/intel/e1000e/ptp.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Tested-by: Mor Bar-Gabay <morx.bar.gabay@xxxxxxxxx>