Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter

[Dawid Osuchowski]

On 2025-07-17 10:46 AM, Yuto Ohnuki wrote:
> Remove hw_rx_no_dma_resources and eitr_param fields from struct
> ixgbevf_adapter since these fields are never referenced in the driver.
>
> Note that the interrupt throttle rate is controlled by the
> rx_itr_setting and tx_itr_setting variables.
>
> This change simplifies the ixgbevf driver by removing unused fields,
> which improves maintainability.
>
> Signed-off-by: Yuto Ohnuki <ytohnuki@xxxxxxxxxx>
> ---
>   drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> index 4384e892f967..3a379e6a3a2a 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
>   	int num_rx_queues;
>   	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active queue */
>   	u64 hw_csum_rx_error;
> -	u64 hw_rx_no_dma_resources;
>   	int num_msix_vectors;
>   	u64 alloc_rx_page_failed;
>   	u64 alloc_rx_buff_failed;
> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
>   	/* structs defined in ixgbe_vf.h */
>   	struct ixgbe_hw hw;
>   	u16 msg_enable;
> -	/* Interrupt Throttle Rate */
> -	u32 eitr_param;
>   
>   	struct ixgbevf_hw_stats stats;
>   

Reviewed-by: Dawid Osuchowski <dawid.osuchowski@xxxxxxxxxxxxxxx>

Thanks,
Dawid