Re: [PATCH net-next 2/2] net: hibmcge: Add support for PHY LEDs on YT8521

From: Jijie Shao
Date: Thu Jul 17 2025 - 04:40:42 EST



on 2025/7/17 0:42, Andrew Lunn wrote:
On Wed, Jul 16, 2025 at 06:00:41PM +0800, Jijie Shao wrote:
hibmcge is a PCIE EP device, and its controller is
not on the board. And board uses ACPI not DTS
to create the device tree.

So, this makes it impossible to add a "reg" property(used in of_phy_led())
for hibmcge. Therefore, the PHY_LED framework cannot be used directly.

This patch creates a separate LED device for hibmcge
and directly calls the phy->drv->led_hw**() function to
operate the related LEDs.
Extending what Russell said, please take a look at:

Documentation/firmware-guide/acpi/dsd/phy.rst

and extend it to cover PHY LEDs.

Andrew

Sure. I'll take a look at this.

Thanks,
Jijie Shao