RE: [PATCH 1/5] phy: samsung-ufs: update calibration settings for EVT2

From: Alim Akhtar
Date: Wed Jul 16 2025 - 23:32:45 EST


Hi Sowon,

> -----Original Message-----
> From: Sowon Na <sowon.na@xxxxxxxxxxx>
> Sent: Wednesday, July 2, 2025 7:03 AM
> To: robh@xxxxxxxxxx; krzk@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> vkoul@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; kishon@xxxxxxxxxx
> Cc: krzk+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> sowon.na@xxxxxxxxxxx
> Subject: [PATCH 1/5] phy: samsung-ufs: update calibration settings for EVT2
>
> The hardware EVT version for exynosautov920 has been updated, with EVT2
> confirmed as the final production version. Accordingly, this patch updates the
> UFS PHY calibration settings to match EVT2 hardware characteristics.
>
This patch does more then what is mentioned here,
please update the commit with all the changes so that we understand why the changes was done.
.
.
.[snip]
> -#define EXYNOSAUTOV920_CDR_LOCK_OFFSET
> 0xce4
> -
> +#define EXYNOSAUTOV920_CAL_DONE_OFFSET
> 0xce0
Any reason for not using CRD lock and using Cal Done?