Re: [PATCH net-next v6] tcp: trace retransmit failures in tcp_retransmit_skb

From: fan.yu9
Date: Wed Jul 16 2025 - 22:13:14 EST


> > print fmt: "skbaddr=%p skaddr=%p family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s err=%d"

> >

> > Suggested-by: KuniyukiIwashima <kuniyu@xxxxxxxxxx>

> I don't deserve this tag.  (Also, a space between first/last name is missing.)

> Suggested-by can be used when the core idea is provided by someone,

> but not when someone just reviews the patch and points out something

> wrong.

> But code-wise, the change looks good to me.

> Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>

Hi Kuniyuki,


Thank you for your thorough review and guidance - it's greatly appreciated.

I'll submit v7 with corrected tags :).