Re: [PATCH 7/7] clk: qcom: gcc: Add support for Global Clock Controller

[Krzysztof Kozlowski]

On 16/07/2025 17:20, Pankaj Patil wrote:
> From: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> 
> Add support for Global clock controller for Glymur platform.
> 
> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> Signed-off-by: Pankaj Patil <pankaj.patil@xxxxxxxxxxxxxxxx>
> ---
>  drivers/clk/qcom/Kconfig      |   10 +
>  drivers/clk/qcom/Makefile     |    1 +
>  drivers/clk/qcom/gcc-glymur.c | 8623 +++++++++++++++++++++++++++++++++
>  3 files changed, 8634 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-glymur.c
> 
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 051301007aa6..1d9e8c6aeaed 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -645,6 +645,16 @@ config SAR_GPUCC_2130P
>  	  Say Y if you want to support graphics controller devices and
>  	  functionality such as 3D graphics.
>  
> +config SC_GCC_GLYMUR

G > 7, please order alphanumerically.

> +	tristate "GLYMUR Global Clock Controller"
> +	select QCOM_GDSC
> +	depends on COMMON_CLK_QCOM
> +	depends on ARM64 || COMPILE_TEST
> +	help
> +	  Support for the global clock controller on GLYMUR devices.
> +	  Say Y if you want to use peripheral devices such as UART, SPI,
> +	  I2C, USB, UFS, SDCC, etc.
> +
>  config SC_GCC_7180
>  	tristate "SC7180 Global Clock Controller"
>  	select QCOM_GDSC
> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
> index bf95729678f6..cdc3d9ba9024 100644
> --- a/drivers/clk/qcom/Makefile
> +++ b/drivers/clk/qcom/Makefile
> @@ -94,6 +94,7 @@ obj-$(CONFIG_SA_GPUCC_8775P) += gpucc-sa8775p.o
>  obj-$(CONFIG_SA_VIDEOCC_8775P) += videocc-sa8775p.o
>  obj-$(CONFIG_SAR_GCC_2130P) += gcc-sar2130p.o
>  obj-$(CONFIG_SAR_GPUCC_2130P) += gpucc-sar2130p.o
> +obj-$(CONFIG_SC_GCC_GLYMUR) += gcc-glymur.o

Same here

>  obj-$(CONFIG_SC_GCC_7180) += gcc-sc7180.o
>  obj-$(CONFIG_SC_GCC_7280) += gcc-sc7280.o
>  obj-$(CONFIG_SC_GCC_8180X) += gcc-sc8180x.o
> diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c
> new file mode 100644
> index 000000000000..a1a6da62ed35
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-glymur.c
> @@ -0,0 +1,8623 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.

Missing date.


Best regards,
Krzysztof