Re: [PATCH liburing v2 0/3] Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build error
From: Alviro Iskandar Setiawan
Date: Wed Jul 16 2025 - 10:28:42 EST
On Wed, Jul 16, 2025 at 7:41 PM Jens Axboe wrote:
> For patch 1, maybe just bring back the configure test and not bother
> with a revert style commit? There is nothing in test/ that uses
> memfd_create, so there's no point bringing it back in there.
Ah yea. That'd be easier. I'll copy the configure part instead of
modifying the git revert result 😆
> IOW, patch 2 can be dropped, as it's really just dropping bits
> that patch 1 re-added for some reason.
>
> All that's needed is to add it to the examples/ helpers. If it's
> needed for test/ later, then it can get added at that time.
>
> All of that to say, I'd just add the configure bit and the examples/
> helper in a single patch and not worry about test/ at all.
Understandable. I'll send a v3 revision shortly.
-- Viro