Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"

From: Liam R. Howlett
Date: Wed Jul 16 2025 - 10:00:14 EST


* Dishank Jogi <dishank.jogi@xxxxxxxxx> [250716 05:35]:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
>
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
>
> Signed-off-by: Dishank Jogi <dishank.jogi@xxxxxxxxx>

Reviewed-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>

> ---
> kernel/fork.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
> }
> #endif
>
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> struct clone_args __user *uargs,
> size_t usize)
> {
> --
> 2.25.1
>