Re: [PATCH v3] x86/boot: Avoid writing to cr4 twice in startup_64()

[Borislav Petkov]

On Wed, Jul 16, 2025 at 09:07:20AM +0000, Khalid Ali wrote:
> I think the comment is misplaced. It is better if we move starting from "from the SDM"
> to below the endif. The second move the comment above it isn't useful also everyone knows 
> what PGE bit does, so it is better if we replace with the above misplaced comment.

The comment's fine. The %cr4 writes need a comment explaining what
they do because their sequence is special.

I don't mind documenting non-obvious asm in a more detailed fashion.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette