Re: [PATCH v2] staging: sound: Adjust mutex unlock order

[Takashi Iwai]

On Wed, 16 Jul 2025 10:18:04 +0200,
Erick Karanja wrote:
> 
> The mutexes qdev_mutex and chip->mutex are acquired in that order
> throughout the driver. To preserve proper lock hierarchy and avoid
> potential deadlocks, they must be released in the reverse
> order of acquisition.
> 
> This change reorders the unlock sequence to first release chip->mutex
> followed by qdev_mutex, ensuring consistency with the locking pattern.
> 
> changes since v1:
>    - Applied the unlock reordering in other functions with this pattern.
> 
> Signed-off-by: Erick Karanja <karanja99erick@xxxxxxxxx>

The code change looks good, but could you resubmit with the proper
subject prefix (e.g. "ALSA: usb: qcom:"), and with a Fixes tag?


thanks,

Takashi