Re: [PATCH v7 04/15] media: qcom: camss: Add support for PHY API devices

[Bryan O'Donoghue]

On 16/07/2025 10:36, Loic Poulain wrote:
> > +       if (!phy_np) {
> > +               if (!res->legacy_phy)
> > +                       return -ENODEV;
> > +
> > +               for (i = 0; i < camss->res->csiphy_num; i++) {
> > +                       ret = msm_csiphy_subdev_init_legacy(camss, &camss->csiphy[i],
> > +                                                           &res->csiphy_res[i],
> > +                                                           res->csiphy_res[i].csiphy.id);
> > +                       if (ret < 0) {
> > +                               dev_err(camss->dev,
> > +                                       "Failed to init csiphy%d sub-device: %d\n",
> > +                                       i, ret);
> > +                               return ret;
> > +                       }
> > +                       camss->csiphy[i].phy = ERR_PTR(-ENODEV);
> >                  }
> So what happens if we have `phy_np` and `!of_device_is_available`, we
> just continue without any phy initialized?

Hmm. Good question.

Yes but, that's probably not what we want.

Thanks, I will look into this.

---
bod