Re: [PATCH] gpiolib: devres: release GPIOs in devm_gpiod_put_array()
From: Andy Shevchenko
Date: Wed Jul 16 2025 - 05:31:03 EST
On Wed, Jul 16, 2025 at 11:09:31AM +0200, Bartosz Golaszewski wrote:
> On Tue, 15 Jul 2025 17:00:20 +0100, André Draszik wrote:
> > devm_gpiod_put_array() is meant to undo the effects of
> > devm_gpiod_get_array() - in particular, it should release the GPIOs
> > contained in the array acquired with the latter. It is meant to be the
> > resource-managed version of gpiod_put_array(), and it should behave
> > similar to the non-array version devm_gpiod_put().
> >
> > Since commit d1d52c6622a6 ("gpiolib: devres: Finish the conversion to
> > use devm_add_action()") it doesn't do that anymore, it just removes the
> > devres action and frees associated memory, but it doesn't actually
> > release the GPIOs.
[...]
> Thanks for catching it, I queued it for v6.16-rc7.
Yeah, I used the release function in parameter, but not changed the call.
Thanks for a good catch!
--
With Best Regards,
Andy Shevchenko