Re: [PATCH] nvmet: Add support for FDP devices in fabrics passthru path

[Nitesh Shetty]

On 15/07/25 10:09AM, Christoph Hellwig wrote:
> On Tue, Jul 15, 2025 at 11:48:04AM +0530, Nitesh Shetty wrote:
> > In nvmet passthru path FDP is disabled, because of failure of
> > admin_get_features FDP(0x1d) feature command.
> > Supporting this through nvmet_setup_passthru_command enables FDP.
>
> I don't think this is safe - the feature has endurance group scope
> and thus can affect other controllers not passed through as well.
Agree, how about only enabling only for nvme_admin_get_features,
but not for nvme_admin_set_features, something like below?

--- a/drivers/nvme/target/passthru.c
+++ b/drivers/nvme/target/passthru.c
@@ -533,6 +533,8 @@ u16 nvmet_parse_passthru_admin_cmd(struct nvmet_req *req)
 		case NVME_FEAT_HOST_ID:
 			req->execute = nvmet_execute_get_features;
 			return NVME_SC_SUCCESS;
+		case NVME_FEAT_FDP:
+			return nvmet_setup_passthru_command(req);
 		default:
 			return nvmet_passthru_get_set_features(req);
 		}

Thanks,
Nitesh