Re: [PATCH 06/25] media: iris: Allow substate transition to load resources during output streaming

[Vikash Garodia]

On 7/4/2025 1:23 PM, Dikshita Agarwal wrote:
> Previously, the transition to load resources substate was only allowed
> when instance state was INIT, since capture port streaming was not
> permitted before output port streaming in the driver.
> However, now after removing that restriction, the instance state can be
> OUTPUT_STREAMING when firmware start is triggered and substate needs to
> be moved to LOAD_RESOURCES.
> 
> Fixes: 547f7b8c5090 ("media: iris: add check to allow sub states transitions")
> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/iris/iris_state.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c
> index 104e1687ad39dab93ff66450ba3a97c309b1e1e1..a21238d2818f9606871953bd0bee25382cca0474 100644
> --- a/drivers/media/platform/qcom/iris/iris_state.c
> +++ b/drivers/media/platform/qcom/iris/iris_state.c
> @@ -122,7 +122,8 @@ static bool iris_inst_allow_sub_state(struct iris_inst *inst, enum iris_inst_sub
>  		return false;
>  	case IRIS_INST_OUTPUT_STREAMING:
>  		if (sub_state & (IRIS_INST_SUB_DRC_LAST |
> -			IRIS_INST_SUB_DRAIN_LAST | IRIS_INST_SUB_OUTPUT_PAUSE))
> +			IRIS_INST_SUB_DRAIN_LAST | IRIS_INST_SUB_OUTPUT_PAUSE |
> +			IRIS_INST_SUB_LOAD_RESOURCES))
>  			return true;
>  		return false;
>  	case IRIS_INST_STREAMING:
> 

Reviewed-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>