Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support
From: Thomas Weißschuh
Date: Wed Jul 16 2025 - 01:30:59 EST
On Mon, Jul 14, 2025 at 07:52:28AM +0200, Thomas Weißschuh wrote:
> On Fri, Jul 11, 2025 at 04:44:23PM +0100, Al Viro wrote:
(...)
> > On Fri, Jul 11, 2025 at 12:35:59PM +0200, Thomas Weißschuh wrote:
> > > could you take a look at these new symbol exports?
> >
> > > > +EXPORT_SYMBOL_GPL_FOR_MODULES(put_filesystem, "kunit-uapi");
> >
> > What's that one for???
>
> What are you referring to?
Reading this again you probably asked why put_filesystem() is exported.
As I see it, that should be called after being done with the return value of
get_fs_type(). Not that it does anything for the always built-in ramfs.
The alternatives I see are a commented-out variant with an explanation or
making put_filesystem() into an inline function.
Thomas