Re: [PATCH] hfsplus: don't use BUG_ON() in hfsplus_create_attributes_file()

[Tetsuo Handa]

On 2025/07/07 23:22, Yangtao Li wrote:
> 161         case HFSPLUS_VALID_ATTR_TREE:
> 162                 return 0;
> 163         case HFSPLUS_FAILED_ATTR_TREE:
> 164                 return -EOPNOTSUPP;
> 165         default:
> 166                 BUG();
> 167         }
> 
> I haven't delved into the implementation details of xattr yet, but
> there is a bug in this function. It seems that we should convert
> the bug to return EIO in another patch?

I don't think this BUG() is triggerable. attr_tree_state is an atomic_t
which can take only one of HFSPLUS_EMPTY_ATTR_TREE, HFSPLUS_VALID_ATTR_TREE,
HFSPLUS_FAILED_ATTR_TREE or HFSPLUS_CREATING_ATTR_TREE.