Re: [PATCH net-next v13 12/12] dpll: zl3073x: Add support to get/set frequency on pins

From: Vadim Fedorenko
Date: Mon Jul 07 2025 - 09:05:14 EST


On 07/07/2025 09:32, Jiri Pirko wrote:
Fri, Jul 04, 2025 at 08:22:02PM +0200, ivecera@xxxxxxxxxx wrote:

[...]

+static int
+zl3073x_dpll_input_pin_frequency_set(const struct dpll_pin *dpll_pin,
+ void *pin_priv,
+ const struct dpll_device *dpll,
+ void *dpll_priv, u64 frequency,
+ struct netlink_ext_ack *extack)

Unrelated to this patch, but ny idea why we don't implement
"FREQUENCY_CAN_CHANGE" capability. I think we are missing it.

Do you mean that some DPLLs may implement fixed frequency pins and
we have to signal it back to user-space?