Re: [PATCH v3 2/2] tracing/preemptirq: Optimize preempt_disable/enable() tracepoint overhead
From: kernel test robot
Date: Mon Jul 07 2025 - 06:30:49 EST
Hi Wander,
kernel test robot noticed the following build errors:
[auto build test ERROR on trace/for-next]
[also build test ERROR on tip/sched/core linus/master v6.16-rc5 next-20250704]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wander-Lairson-Costa/trace-preemptirq-reduce-overhead-of-irq_enable-disable-tracepoints/20250705-011058
base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link: https://lore.kernel.org/r/20250704170748.97632-3-wander%40redhat.com
patch subject: [PATCH v3 2/2] tracing/preemptirq: Optimize preempt_disable/enable() tracepoint overhead
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20250707/202507071800.OViM30Fr-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250707/202507071800.OViM30Fr-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507071800.OViM30Fr-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from include/linux/irqflags.h:18,
from arch/m68k/include/asm/atomic.h:6,
from include/linux/atomic.h:7,
from include/linux/jump_label.h:257,
from include/linux/static_key.h:1,
from include/linux/tracepoint-defs.h:11,
from include/linux/preempt.h:13,
from arch/m68k/include/asm/processor.h:11,
from include/linux/sched.h:13,
from arch/m68k/kernel/asm-offsets.c:15:
arch/m68k/include/asm/irqflags.h: In function 'arch_local_irq_enable':
>> arch/m68k/include/asm/irqflags.h:44:29: error: implicit declaration of function 'hardirq_count' [-Wimplicit-function-declaration]
44 | if (MACH_IS_Q40 || !hardirq_count())
| ^~~~~~~~~~~~~
make[3]: *** [scripts/Makefile.build:98: arch/m68k/kernel/asm-offsets.s] Error 1
make[3]: Target 'prepare' not remade because of errors.
make[2]: *** [Makefile:1274: prepare0] Error 2
make[2]: Target 'prepare' not remade because of errors.
make[1]: *** [Makefile:248: __sub-make] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/hardirq_count +44 arch/m68k/include/asm/irqflags.h
df9ee29270c11d David Howells 2010-10-07 31
df9ee29270c11d David Howells 2010-10-07 32 static inline void arch_local_irq_enable(void)
df9ee29270c11d David Howells 2010-10-07 33 {
df9ee29270c11d David Howells 2010-10-07 34 #if defined(CONFIG_COLDFIRE)
df9ee29270c11d David Howells 2010-10-07 35 asm volatile (
df9ee29270c11d David Howells 2010-10-07 36 "move %/sr,%%d0 \n\t"
df9ee29270c11d David Howells 2010-10-07 37 "andi.l #0xf8ff,%%d0 \n\t"
df9ee29270c11d David Howells 2010-10-07 38 "move %%d0,%/sr \n"
df9ee29270c11d David Howells 2010-10-07 39 : /* no outputs */
df9ee29270c11d David Howells 2010-10-07 40 :
df9ee29270c11d David Howells 2010-10-07 41 : "cc", "%d0", "memory");
df9ee29270c11d David Howells 2010-10-07 42 #else
df9ee29270c11d David Howells 2010-10-07 43 # if defined(CONFIG_MMU)
df9ee29270c11d David Howells 2010-10-07 @44 if (MACH_IS_Q40 || !hardirq_count())
df9ee29270c11d David Howells 2010-10-07 45 # endif
df9ee29270c11d David Howells 2010-10-07 46 asm volatile (
df9ee29270c11d David Howells 2010-10-07 47 "andiw %0,%%sr"
df9ee29270c11d David Howells 2010-10-07 48 :
df9ee29270c11d David Howells 2010-10-07 49 : "i" (ALLOWINT)
df9ee29270c11d David Howells 2010-10-07 50 : "memory");
df9ee29270c11d David Howells 2010-10-07 51 #endif
df9ee29270c11d David Howells 2010-10-07 52 }
df9ee29270c11d David Howells 2010-10-07 53
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki