Re: [PATCH 05/20] clocksource/drivers/vf_pit: Pass the cpu number as parameter

[Ghennadi Procopciuc]

On 7/5/2025 7:01 PM, Daniel Lezcano wrote:
> In order to initialize the timer with a cpumask tied to a cpu, let's
> pass it as a parameter instead of hardwiring it in the init function.
> 
> No functional changes intended.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
>  drivers/clocksource/timer-vf-pit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
> index 34edb23194c5..20f637c8e856 100644
> --- a/drivers/clocksource/timer-vf-pit.c
> +++ b/drivers/clocksource/timer-vf-pit.c
> @@ -147,7 +147,7 @@ static irqreturn_t pit_timer_interrupt(int irq, void *dev_id)
>  }
>  
>  static int __init pit_clockevent_init(struct pit_timer *pit, void __iomem *base,
> -				      unsigned long rate, int irq)
> +				      unsigned long rate, int irq, int cpu)

I noticed that cpumask_of() and get_cpu_mask() expect an 'unsigned int cpu' rather than an 'int cpu'. Would you consider updating the type of the cpu parameter accordingly?

-- 
Regards,
Ghennadi