Re: [PATCH 3/4] hfsplus: enable uncached buffer io support

[Viacheslav Dubeyko]

On Thu, 2025-06-26 at 11:30 -0600, Yangtao Li wrote:
> Now cont_write_begin() support DONTCACHE mode, let's set
> FOP_DONTCACHE
> flag to enable uncached buffer io support for hfsplus.
> 
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> ---
>  fs/hfsplus/inode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 26cc150856b9..b790ffe92019 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -372,6 +372,7 @@ static const struct file_operations
> hfsplus_file_operations = {
>  	.open		= hfsplus_file_open,
>  	.release	= hfsplus_file_release,
>  	.unlocked_ioctl = hfsplus_ioctl,
> +	.fop_flags	= FOP_DONTCACHE,
>  };
>  
>  struct inode *hfsplus_new_inode(struct super_block *sb, struct inode
> *dir,

The same question for HFS+. Because, it is again old and pretty
obsolete file system. :) The main use-case is simply support the
capability to mount HFS+ volume is created under Mac OS X, for example,
and to access the data there. What is the point to support this feature
in HFS+? Currently, around 200 xfstests fails in HFS/HFS+. We even
cannot test any new functionality properly. And guys reports bugs in
existing functionality. We need to be focused on this right now. Sorry,
HFS/HFS+ is not so good ground for implementing new features. :)
We really need to stabilize the existing functionality right now. And
we have a lot of work yet. :) 

Thanks,
Slava.