Re: [PATCH 7/7] docs: kdoc: pretty up dump_enum()

From: Mauro Carvalho Chehab
Date: Thu Jul 03 2025 - 18:29:31 EST


Em Thu, 03 Jul 2025 12:17:42 -0600
Jonathan Corbet <corbet@xxxxxxx> escreveu:

> Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes:
>
> > Em Tue, 1 Jul 2025 14:57:30 -0600
> > Jonathan Corbet <corbet@xxxxxxx> escreveu:
> >
> >> self.emit_msg(ln,
> >> - f"expecting prototype for enum {self.entry.identifier}. Prototype was for enum {declaration_name} instead")
> >> + f"expecting prototype for enum {self.entry.identifier}. "
> >> + f"Prototype was for enum {declaration_name} instead")
> >
> > Even being a big one, my personal preference would be to break the long
> > string here, as keeping together is easier for grep, but yeah, I also
> > considered breaking it ;-)
>
> Did you mean your preference would be to *not* break it?

What I meant is that I was in doubt myself of breaking long lines or
not... I opted to not break.

Yet, if you feel it looks better breaking it, go for it ;-)

> There's a non-greppable piece at the break point anyway, so I wasn't
> anticipating making life harder for anybody there.
>
> Thanks,
>
> jon



Thanks,
Mauro