Re: [PATCH v1 0/5] perf test: Sanity check file descriptors are cleaned up

[Namhyung Kim]

On Wed, Jul 02, 2025 at 08:03:08PM -0700, Ian Rogers wrote:
> On Wed, Jul 2, 2025 at 7:20 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > On Tue, Jun 24, 2025 at 12:03:20PM -0700, Ian Rogers wrote:
> > > Some recent patches showed we were leaking file descriptors:
> > > https://lore.kernel.org/lkml/20250617223356.2752099-2-irogers@xxxxxxxxxx/
> > >
> > > When a test is forked the file descriptors >3 can be closed and then
> > > any file descriptors >3 left after the test are leaks. Add this
> > > checking to the forked test code. Prior to that clean up some file
> > > descriptor usage so we can assert that only file descriptors are
> > > cleaned up. Sometimes the file descriptor being held open is the
> > > result of a memory leak, so fix those.
> >
> > Interesting, I can see a few more tests are failing with this.  But we
> > can figure it out later.
> 
> That's cool. I was a little disappointed that just the dso kcore leak
> was found by this. I was also surprised that the dso kcore memory leak
> hadn't shown up with leak sanitizer and reference count checking. Let
> me know if there is anything more I need to do to the patch series.

Applied to perf-tools-next, thanks!

Best Regards,
Namhyung