Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()

From: Laurent Pinchart
Date: Thu Jul 03 2025 - 14:03:31 EST


On Thu, Jun 26, 2025 at 11:30:18AM +0300, Laurent Pinchart wrote:
> On Thu, Jun 26, 2025 at 03:32:50AM +0300, Dan Carpenter wrote:
> > On Thu, Jun 26, 2025 at 03:20:53AM +0300, Laurent Pinchart wrote:
> > > On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> > > > This was returning IS_ERR() where PTR_ERR() was intended.
> > > >
> > > > Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
> > >
> > > I'll add a
> > >
> > > Cc: stable@xxxxxxxxxxxxxxx
> > >
> > > to obey the media subsystem CI rules.
> >
> > Wait, what? The original commit hasn't hit Linus's tree and it's
> > not marked for stable either.
>
> I'm personally not in favour of adding Cc: stable on all patches that
> have a Fixes: line. I'll let Mauro defend the rule, and I'm happy to
> drop the Cc line and fix the CI.

Mauro, could you please tell what would be your preference ?

--
Regards,

Laurent Pinchart