Re: [PATCH] mtd: spi-nor: Fix spi_nor_try_unlock_all()

From: Pratyush Yadav
Date: Thu Jul 03 2025 - 11:22:22 EST


On Tue, Jul 01 2025, Michael Walle wrote:

> Commit ff67592cbdfc ("mtd: spi-nor: Introduce spi_nor_set_mtd_info()")
> moved all initialization of the mtd fields at the end of spi_nor_scan().
> Normally, the mtd info is only needed for the mtd ops on the device,
> with one exception: spi_nor_try_unlock_all(), which will also make use
> of the mtd->size parameter. With that commit, the size will always be
> zero because it is not initialized. Fix that by not using the size of
> the mtd_info struct, but use the size from struct spi_nor_flash_parameter.
>
> Fixes: ff67592cbdfc ("mtd: spi-nor: Introduce spi_nor_set_mtd_info()")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Jean-Marc Ranger <jmranger@xxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/DM6PR06MB561177323DC5207E34AF2A06C547A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> Tested-by: Jean-Marc Ranger <jmranger@xxxxxxxxxxx>
> Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx>

This patch hasn't had much time on the list but we are already at -rc4
and I want it to get some time in linux-next. If later reviews come in
and changes are needed, I can drop it and apply the new version. So
applied to spi-nor/next. Thanks!

[...]

--
Regards,
Pratyush Yadav