Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static

From: Shiji Yang
Date: Thu Jul 03 2025 - 09:26:11 EST


On Wed, 2 Jul 2025 14:06:28 +0200, Thomas Bogendoerfer wrote:

> On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote:
> > These functions are only used in the current source file "vpe-mt.c".
> > Do not export them and mark them as static to silence the missing
> > prototypes warnings:
>
> you are breaking the whole idea of this interface, The functions are
> exported for other kernel modules. By removing it you break them.
>
> If we know that this interface is unsued, we should remove the
> whole kernel module, but I don't know if it used somewhere.
>
> Thomas.

Thank you for your review. It seems that MIPS/Lantiq platform still
rely on the vpe-mt module. I've sent another patch to fix these
vpe-mt compilation warnings. Suppress patches 12 and 13:

https://lore.kernel.org/linux-mips/OSBPR01MB16706BF0ABF807E870C79A86BC43A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

Regards,
Shiji Yang