Re: [PATCH 1/2] mmc: sdhci-cadence: use of_property_present

[Ulf Hansson]

On Thu, 26 Jun 2025 at 16:44, Benoît Monin <benoit.monin@xxxxxxxxxxx> wrote:
>
> Instead of using of_property_read_bool to check the presence of the
> cdns,phy-* properties in the device tree, use of_property_present in
> function sdhci_cdns_phy_param_count.
>
> This silences the following warning messages since the cdns,phy-*
> properties are all u32, not boolean.
>
> OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-input-delay-legacy' with a value.
> OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-input-delay-mmc-highspeed' with a value.
> OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-input-delay-mmc-ddr' with a value.
> OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-dll-delay-sdclk' with a value.
> OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-dll-delay-sdclk-hsmmc' with a value.
>
> Signed-off-by: Benoît Monin <benoit.monin@xxxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-cadence.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index a94b297fcf2a..27bd2eb29948 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -144,7 +144,7 @@ static unsigned int sdhci_cdns_phy_param_count(struct device_node *np)
>         int i;
>
>         for (i = 0; i < ARRAY_SIZE(sdhci_cdns_phy_cfgs); i++)
> -               if (of_property_read_bool(np, sdhci_cdns_phy_cfgs[i].property))
> +               if (of_property_present(np, sdhci_cdns_phy_cfgs[i].property))
>                         count++;
>
>         return count;