Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP

From: Krzysztof Kozlowski
Date: Thu Jul 03 2025 - 07:37:53 EST


On 03/07/2025 13:18, Prasad Kumpatla wrote:
>>
>>> enabled using power domains in lpass-va-macro which is not applicable
>>> for ADSP based platform.
>>>
>>> Reference:
>>> - qcom,lpass-tx-macro.yaml
>>> - qcom,lpass-rx-macro.yaml
>>
>> I don't understand this reference.
>
> Please refer below link for more info. Which is similar kind of
> properties used.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml#n72
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml#n77
I don't understand what is has to do with commit msg. Please
explain/describe in the commit msg the hardware, not point to external
references. No one is going to look to other files to understand why
this commit is like that. This commit must stand on its own.

Best regards,
Krzysztof